Skip to content

Test CI on a blank PR#9228

Open
ddustin wants to merge 1 commit into
ElementsProject:masterfrom
ddustin:ddustin/pr_test
Open

Test CI on a blank PR#9228
ddustin wants to merge 1 commit into
ElementsProject:masterfrom
ddustin:ddustin/pr_test

Conversation

@ddustin

@ddustin ddustin commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Lagrang3

Copy link
Copy Markdown
Collaborator

I thought there was a rule somewhere that would make your CI fail if there wasn't any commit with a Changelog

@ddustin

ddustin commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

I thought there was a rule somewhere that would make your CI fail if there wasn't any commit with a Changelog

Yup yup 💯. I updated the commit to have a Changelog.

@Lagrang3

Lagrang3 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

OK. So this fail (https://github.com/ElementsProject/lightning/actions/runs/27689149066/job/81897831533?pr=9228)

['lightningd-1 2026-06-17T13:21:33.529Z **BROKEN** plugin-cln-xpay: askrene-age failed with {"code":-32601,"message":"Unknown command \'askrene-age\'"}']

should be fixed by this PR 9214, just merged.
Rebase and try again.

Changelog-None
@Lagrang3

Copy link
Copy Markdown
Collaborator
FAILED tests/test_pay.py::test_sendpay_grouping - AssertionError: assert ['pending', 'pending', 'complete'] == ['failed', 'failed', 'complete']

@madelinevibes madelinevibes added this to the v26.09 milestone Jun 22, 2026
@madelinevibes madelinevibes requested a review from Lagrang3 June 22, 2026 03:34
@madelinevibes madelinevibes removed this from the v26.09 milestone Jun 22, 2026
@Lagrang3

Lagrang3 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

@ddustin: I've fixed another flaky test (#9241), you may rebase on top of that and rerun the tests.

I am already finding more flakes:

FAILED tests/test_plugin.py::test_bwatch_reorg_1_block - TimeoutError: Unable to find "[re.compile('Reorg detected')]" in logs.
FAILED tests/test_closing.py::test_htlc_rexmit_while_closing - ValueError: Timeout while waiting for <function test_htlc_rexmit_while_closing.<locals>.<lambda> at 0x7f41553a32e0>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants